[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#68213: 30.0.50; completion-preview-tests failure in --without-x buil
From: |
Eshel Yaron |
Subject: |
bug#68213: 30.0.50; completion-preview-tests failure in --without-x build |
Date: |
Wed, 03 Jan 2024 08:20:37 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
john muhl <jm@pub.pink> writes:
> Eshel Yaron <me@eshelyaron.com> writes:
>
>> FWIW, I was going to suggest the attached patch, following how
>> flymake.el handles this. But if the current solution works, that seems
>> just as good.
>>
> lisp/completion-preview-tests.el:23:2: Error: Duplicate
> definition for key: "<mouse-5>" (keymap (mouse-5 .
> completion-preview-prev-candidate) (down-mouse-2 .
> completion-at-point) (C-down-mouse-1 . completion-at-point)
> (down-mouse-1 . completion-preview-insert))
Ah I can see that, thanks. IMO `defvar-keymap` is too strict in this
case: the "duplicate" definition is not erroneous, it just happens to be
redundant with some values of the `mwheel` variables. There's been some
discussion around that in bug#56873, FWIW. So ISTM that the best way
forward would be to make `defvar-keymap` more lax, perhaps optionally
with a `:lax` keyword argument or some such. Any other ideas?
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build, john muhl, 2024/01/02
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build, Eli Zaretskii, 2024/01/02
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build, Eshel Yaron, 2024/01/02
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build, john muhl, 2024/01/02
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build,
Eshel Yaron <=
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build, Eli Zaretskii, 2024/01/03
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build, Eshel Yaron, 2024/01/03
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build, Eli Zaretskii, 2024/01/03
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build, Eshel Yaron, 2024/01/05
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build, Eli Zaretskii, 2024/01/05
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build, Stefan Monnier, 2024/01/07
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build, Eli Zaretskii, 2024/01/07
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build, Stefan Monnier, 2024/01/07
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build, Po Lu, 2024/01/07
- bug#68213: 30.0.50; completion-preview-tests failure in --without-x build, Stefan Monnier, 2024/01/07