bug#68213: 30.0.50; completion-preview-tests failure in --without-x build

[Stefan Monnier]

I just pushed to `scratch/mwheel-no-alts` a set of patches which
I intend to push to `master` soon.

They should fix the test failure in `completion-preview`, and they get
rid of the `mouse-wheel-*-alternate-event`s.

Any comments/objections while I work on the corresponding etc/NEWS and
Texinfo changes?


        Stefan


commit ee2a8fd4cff84cd5bd672fdde8ec3e0800f132be
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Tue Jan 9 11:34:05 2024 -0500

    (mouse-wheel-*-event): Minor cleanups
    
    * lisp/mwheel.el (mwheel-event-button): Mark as obsolete alias.
    Change all callers.
    
    * lisp/edmacro.el (mouse-wheel-*-event): Move declarations to ...
    (edmacro-fix-menu-commands): ... where we do know that they should
    be defined.  Obey `mouse-wheel-*-alternate-event`s as well.

commit a764b503e126a60ff4ea1266da924de7b020637e
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Fri Jan 12 17:50:09 2024 -0500

    (mwheel--is-dir-p): New macro to reduce code duplication
    
    It also slightly reduces memory allocation.
    
    * lisp/mwheel.el (mwheel--is-dir-p): New macro.
    (mwheel-scroll, mouse-wheel-text-scale)
    (mouse-wheel-global-text-scale): Use it.

commit 3bd8e963f7c8d762551c2528b2f907b613218a08
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Fri Jan 12 18:05:14 2024 -0500

    * lisp/keymap.el (define-keymap): Demote "duplicate def" to a warning

commit b9959e94d26bdd406d506ef355612627a0b1406b
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Fri Jan 12 18:08:31 2024 -0500

    * lisp/completion-preview.el: Fix use in non-GUI session
    
    Fix loading in non-GUI sessions where `mwheel` is not preloaded.
    Not requiring `mwheel` would be a lot more complex, since it would
    require delaying the construction of `completion-preview--mouse-map`.
    
    * lisp/completion-preview.el (<toplevel>): Require `mwheel`.
    Remove correspondingly redundant `defvar`s.
    (completion-preview--mouse-map): Use `key-description` rather than mimicking
    it with `format`.

commit b0f04ce4d3495de8593e3b64ddd218cd3bad221c
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Fri Jan 12 18:28:12 2024 -0500

    mwheel.el: Unconditionally use the `wheel-up/down/...` events
    
    The `mouse-wheel-DIR-event` vars were introduced because under X11
    we get different `mouse-N` events depending on the users' mouse and
    those same events can be used for other things for other rodents, so we
    can't unconditionally treat those events as mouse-wheel events.
    
    But this does not apply to the `wheel-up/down/...` events.
    So hard code them.
    
    * lisp/mwheel.el (mwheel--is-dir-p): Always consider the `wheel-DIR` events.
    (mouse-wheel--setup-bindings): Always bind the `wheel-DIR` events.
    
    * lisp/completion-preview.el (completion-preview--mouse-map):
    Unconditionally bind the `wheel-DIR` events.
    * lisp/edmacro.el (edmacro-fix-menu-commands): Hard code the
    `wheel-DIR` events as mouse events regardless of `mouse-wheel-*-event`s.
    * lisp/progmodes/flymake.el (flymake--mode-line-counter-map):
    Do nothing, because it's already been done in commit e5be6c7ae309.

commit 8cb8b9736532fdd8f2fc734b08ed55c17b922806
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Fri Jan 12 18:52:37 2024 -0500

    mwheel.el: Remove `mouse-wheel-*-alternate-event` vars
    
    Now that `wheel-DIR` events are hardcoded, we never need more than
    one variable (which we actually never needed anyway, we could have
    let `mouse-wheel-*-event` vars hold lists of events instead), so
    remove the `mouse-wheel-*-alternate-event` vars by merging their
    default value into that of the corresponding `mouse-wheel-*-event`.
    
    * lisp/mwheel.el (mouse-wheel-down-event, mouse-wheel-up-event)
    (mouse-wheel-left-event, mouse-wheel-right-event): Don't bother holding
    `wheel-DIR` events since these are already handled anyway.
    Hold the event that would have been held in
    `mouse-wheel-DIR-alternate-event` instead.
    (mouse-wheel-down-alternate-event, mouse-wheel-up-alternate-event)
    (mouse-wheel-left-alternate-event, mouse-wheel-right-alternate-event):
    Delete vars.
    (mwheel--is-dir-p, mouse-wheel--setup-bindings):
    * lisp/edmacro.el (edmacro-fix-menu-commands):
    * lisp/completion-preview.el (completion-preview--mouse-map):
    Don't use `mouse-wheel-up/down-alternate-event` any more.
    * lisp/progmodes/flymake.el (flymake--mode-line-counter-map):
    Do nothing, because it already ignored those vars.

commit f355557bb9e93f5d5e7c3fae17e4da398226efb4
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Fri Jan 12 19:05:24 2024 -0500

    mwheel.el: Code clean to reduce duplication
    
    * lisp/mwheel.el (mouse-wheel-obey-old-style-wheel-buttons): New var,
    extracted from `mouse-wheel-*-event` definitions.
    (mouse-wheel-down-event, mouse-wheel-up-event)
    (mouse-wheel-left-event, mouse-wheel-right-event): Use it.