bug#67393: 29.1; Slow to open file if autosave exists

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Cc: materus213@gmail.com,  yantar92@posteo.net,  67393@debbugs.gnu.org,
>   stefankangas@gmail.com
> Date: Tue, 16 Jan 2024 19:43:09 +0200
> 
> >> > A defcustom would be one option.  'set-important-message' like
> >> > implemented by Ihor would be another option.  All this could be
> >> > added after creating the new function 'important-message'.
> >> 
> >> So here is the new function 'important-message' and its calls
> >> in two discussed places.
> >
> > Is this in preparation for some followup?  Because if not, I'm not
> > sure it is justified to add a short function that has just 2 callers.
> > What do we gain, as a counter-weight to the need to document the new
> > function, insist that new code uses it, etc.?
> 
> Indeed, these 2 test cases are for preparation to using it everywhere.

Then I think we should consider all of those changes together.

> >> I'm not sure why 'after-find-file' uses non-nil NODISP arg
> >> in (sit-for 1 t).  This means is that the message is not
> >> displayed?  Then why 'message' is called?
> >
> > I think it means redisplay is not called.  'message' causes redisplay
> > of the echo-area, but we don't need to redisplay the rest.
> 
> Would it be safe to drop NODISP in the new function?
> I see that most calls of 'message' with 'sit-for'
> don't use the NODISP arg.

I don't see a need to remove it, as one caller that uses it is enough
to justify it, and the price is hardly significant.