bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer

[Jim Porter]

On 1/10/2024 9:55 AM, Sean Whitton wrote:
> > --- a/test/lisp/eshell/em-cmpl-tests.el
> > +++ b/test/lisp/eshell/em-cmpl-tests.el
> > @@ -186,7 +186,7 @@ em-cmpl-test/file-completion/non-unique
> >          (save-excursion
> >            (goto-char (point-max))
> >            (forward-line -1)
> > -         (should (looking-at "Complete, but not unique")))))))
> > +         (should (looking-at "Making completion list...")))))))
> >
> >   (ert-deftest em-cmpl-test/file-completion/glob ()
> >     "Test completion of file names using a glob."
>
> Jim, does this seem reasonable?

Sorry, I missed this the first time around (I've got a lot of other 
stuff I'm trying to balance at the moment). I think this would fix the 
issue, but I've instead pushed 5f5faad2497 which solves this in a 
more-direct way by checking whether the *Completions* buffer is visible. 
That's what the test is really trying to test anyway.