[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#70312: [PATCH] Avoid unnecessary escaping in url-build-query-string
From: |
Dagfinn Ilmari Mannsåker |
Subject: |
bug#70312: [PATCH] Avoid unnecessary escaping in url-build-query-string |
Date: |
Tue, 09 Apr 2024 15:29:00 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi,
While writing a custom URL function for git-link.el I noticed that
url-build-query-string unnecessarily escapes slashes in query parameter
values. Here's a patch that fixes that by passing
url-query-allowed-chars to the url-hexify-string call.
- ilmari
>From ca1dbe67939ac78f5db06d746cd511928a138657 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dagfinn=20Ilmari=20Manns=C3=A5ker?= <ilmari@ilmari.org>
Date: Tue, 9 Apr 2024 15:02:45 +0100
Subject: [PATCH] Avoid unnecessary escaping in url-build-query-string
* lisp/url/url-util.el (url-build-query-string):
Pass url-query-allowed-chars to url-hexify-string to avoid unnecessarily
escaping characters that don't need to be escaped in a query string.
---
lisp/url/url-util.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/url/url-util.el b/lisp/url/url-util.el
index 5f45b98c7a5..4fc0efcdf62 100644
--- a/lisp/url/url-util.el
+++ b/lisp/url/url-util.el
@@ -268,7 +268,8 @@ instead of just \"key\" as in the example above."
(lambda (key-vals)
(let ((escaped
(mapcar (lambda (sym)
- (url-hexify-string (format "%s" sym))) key-vals)))
+ (url-hexify-string (format "%s" sym)
url-query-allowed-chars))
+ key-vals)))
(mapconcat (lambda (val)
(let ((vprint (format "%s" val))
(eprint (format "%s" (car escaped))))
--
2.39.2
- bug#70312: [PATCH] Avoid unnecessary escaping in url-build-query-string,
Dagfinn Ilmari Mannsåker <=