[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#71685: [PATCH] fix shr rendering in tables without tbody
From: |
Eli Zaretskii |
Subject: |
bug#71685: [PATCH] fix shr rendering in tables without tbody |
Date: |
Sat, 06 Jul 2024 10:36:31 +0300 |
> From: JD Smith <jdtsmith@gmail.com>
> Date: Thu, 20 Jun 2024 15:15:32 -0400
>
> It is very common for HTML tables to include a header (<thead>) and/or footer
> (<tfoot>) without using <tbody>. Modern browsers simply supply an implicit
> <tbody>..</tbody> around all the unparented rows in a table. `shr' does not
> handle this common case correctly. Below is an example with <thead> but not
> <tbody>. It prints the header, but then subsumes it again inside the derived
> body, printing the header again in a single cell.
>
> The relevant function which should handle this is `shr--fix-tbody'. The
> included patch to this function simply avoids including `thead` and `tfoot`
> children in the implicit body.
Thanks. I don't see any experts chiming in, so if you are confident
in the patch, and it doesn't fail the existing tests, please install
on the emacs-30 branch, and thanks. Bonus points for adding a test
for this case.
- bug#71685: [PATCH] fix shr rendering in tables without tbody,
Eli Zaretskii <=