[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#72019: [PATCH] Add project argument to project-kill-buffers
From: |
Eli Zaretskii |
Subject: |
bug#72019: [PATCH] Add project argument to project-kill-buffers |
Date: |
Wed, 10 Jul 2024 14:43:19 +0300 |
> Date: Tue, 9 Jul 2024 22:59:46 +0300
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> Hi!
>
> On 09/07/2024 21:31, Spencer Baugh wrote:
> > Tags: patch
> >
> >
> > Previously, project-kill-buffers always called (project-current t). A
> > Lisp program could change what project project-kill-buffers operated
> > on by binding project-current-directory-override. However, in some
> > edge cases (for example, if the project was deleted between looking it
> > up and calling project-kill-buffers) this might fail to detect a
> > project, and so (project-current t) would prompt the user.
> >
> > To avoid this, accept the project to kill buffers for as an argument.
> >
> > * lisp/progmodes/project.el (project-kill-buffers): Take project as an
> > optional argument.
>
> LGTM.
>
> Eli, is this okay for emacs-30?
As I wrote a few minutes ago, I don't think I like this change in
principle, let alone for Emacs 30. Feel free to point out where I'm
wrong or what am I missing.
- bug#72019: [PATCH] Add project argument to project-kill-buffers, Spencer Baugh, 2024/07/09
- bug#72019: [PATCH] Add project argument to project-kill-buffers, Dmitry Gutov, 2024/07/09
- bug#72019: [PATCH] Add project argument to project-kill-buffers,
Eli Zaretskii <=
- bug#72019: [PATCH] Add project argument to project-kill-buffers, Eli Zaretskii, 2024/07/10
- bug#72019: [PATCH] Add project argument to project-kill-buffers, Spencer Baugh, 2024/07/10
- bug#72019: [PATCH] Add project argument to project-kill-buffers, Eli Zaretskii, 2024/07/10
- bug#72019: [PATCH] Add project argument to project-kill-buffers, Spencer Baugh, 2024/07/10
- bug#72019: [PATCH] Add project argument to project-kill-buffers, Eli Zaretskii, 2024/07/10
- bug#72019: [PATCH] Add project argument to project-kill-buffers, Spencer Baugh, 2024/07/10
- bug#72019: [PATCH] Add project argument to project-kill-buffers, Eli Zaretskii, 2024/07/10
- bug#72019: [PATCH] Add project argument to project-kill-buffers, Spencer Baugh, 2024/07/10
- bug#72019: [PATCH] Add project argument to project-kill-buffers, Eli Zaretskii, 2024/07/10
- bug#72019: [PATCH] Add project argument to project-kill-buffers, Dmitry Gutov, 2024/07/10