[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#72097: 30.0.60; [PATCH] Don't add to Eshell history when aborting 'e
From: |
Jim Porter |
Subject: |
bug#72097: 30.0.60; [PATCH] Don't add to Eshell history when aborting 'eshell-command' |
Date: |
Sat, 13 Jul 2024 11:51:46 -0700 |
Steps to reproduce:
emacs -Q
M-x eshell-command RET oops C-g
M-x eshell
<up>
This will show the most-recent command in the Eshell history as "oops".
That's because it was adding to the history in 'minibuffer-exit-hook',
which runs regardless of *how* you exit the minibuffer. This regressed
from 093a360251, and I misunderstood the conditions where
'minibuffer-exit-hook' runs.
Attached is a patch to fix this. Is this ok for the release branch?
0001-Don-t-save-to-history-from-eshell-command-when-abort.patch
Description: Text document
- bug#72097: 30.0.60; [PATCH] Don't add to Eshell history when aborting 'eshell-command',
Jim Porter <=