[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired
From: |
Juri Linkov |
Subject: |
bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command |
Date: |
Thu, 25 Jul 2024 21:08:42 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) |
>> >> Thanks for the patch, now pushed to master.
>> >
>> > Wouldn't it be better to add a new optional argument NO-HIGHLIGHT to
>> > `query-replace-read-args', for stylistic reasons?
>>
>> It's not clear how such arg should be combined with
>> `query-replace-lazy-highlight' in `query-replace-read-args':
>>
>> (defun query-replace-read-args (prompt regexp-flag &optional noerror
>> no-highlight)
>> ...
>> (from (minibuffer-with-setup-hook
>> (minibuffer-lazy-highlight-setup
>> :highlight query-replace-lazy-highlight
>>
>> with `and'? With `or'? With `xor'?
>> `(and query-replace-lazy-highlight (not no-highlight))'?
>
> The installed patch binds query-replace-lazy-highlight to nil and
> shadows the old binding. This would correspond to
>
> (and query-replace-lazy-highlight (not no-highlight))
>
> which looks reasonable in this case: we just an argument to inhibit
> highlighting. Because we never want highlighting in some cases (like
> here).
Agreed, let's add a new argument.
- bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command, Visuwesh, 2024/07/16
- bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command, Juri Linkov, 2024/07/19
- bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command, Visuwesh, 2024/07/19
- bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command, Juri Linkov, 2024/07/23
- bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command, Michael Heerdegen, 2024/07/23
- bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command, Juri Linkov, 2024/07/23
- bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command, Michael Heerdegen, 2024/07/24
- bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command,
Juri Linkov <=
- bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command, Visuwesh, 2024/07/28
- bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command, Juri Linkov, 2024/07/28