bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#74111: [PATCH] New `tmm-menubar' shortcut display style


From: Eli Zaretskii
Subject: bug#74111: [PATCH] New `tmm-menubar' shortcut display style
Date: Fri, 01 Nov 2024 09:16:06 +0200

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 74111@debbugs.gnu.org
> Date: Thu, 31 Oct 2024 23:07:00 +0100
> 
> Here is a new version taking your remarks into account.

Thanks, just a few nits now:

> +(defcustom tmm-shortcut-inside-entry nil
> +  "Highlight the shortcut character in the menu entry's string.
> +When non-nil, the shortcut character will be highlighted into its menu
> +entry's string with the `highlight' face to help identifying it.

I'd rephrase the last sentence like this:

  When non-nil, the first menu-entry's character that acts as a
  shortcut will be highlighted with the `highlight' face to help
  identifying it.

> +        ;; A nil value for pos means that the shortcut is not inside the
> +        ;; string of the menu entry

Please end this comment with a period.  Likewise elsewhere in the
patch.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]