bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#73005: [REGRESSION, BISECTED]: line numbers disappear when pressing


From: David Ponce
Subject: bug#73005: [REGRESSION, BISECTED]: line numbers disappear when pressing `df` in evil-mode
Date: Mon, 4 Nov 2024 10:02:22 +0100
User-agent: Mozilla Thunderbird

On 04/11/2024 2:05 AM, Konstantin Kharlamov wrote:
On Sun, 2024-11-03 at 22:56 +0100, David Ponce wrote:
On 03/11/2024 8:07 PM, Konstantin Kharlamov wrote:
On Sat, 2024-09-21 at 12:02 +0300, Eli Zaretskii wrote:
Ping! Can we please make some progress here?

Hello! Got some spare time, dug into it. Found a few interesting
things:

1. (not really interesting, but…) problem persists in current
master
2. The exact function call that causes the problem is `(kill-all-
local-
variables t)` inside `(work-buffer--release)`. If I remove it,
everything works as before.

     I guess this implies that bug is not in David's commit per se,
but
rather something that's always been present and just got triggered
by
David's commit.
3. There's an unrelated bug that confused this whole research,
since it
seemed like the function is never called: dong `M-x debug-on-entry
string-pixel-width` does nothing even though `string-pixel-width`
is
called.

Hi Konstantin,

Thank you for your report!  This helped me (sort of) reproduce your
issue

Nice! Let me note for the safe case, since you say "sort of", that in
later emails I posted simpler steps to reproduce by just evaluating

        (lookup-key global-map [tab-bar])

which seems to be caused by a side effect of `string-pixel-width'
when
setting `display-line-numbers' to nil.

Could you please try the attached patch and tell me if it fixes the
issue
for you?

Thanks!

Thank you, I confirm it does fix the bug!

Thank you!

Hi Eli,

Would you mind to commit this fix? Here is a possible change log:

2024-11-04  David Ponce  <da_vid@orange.fr>

        * subr-x.el (string-pixel-width): Set text property
        `display-line-numbers-disable' instead of changing the
        buffer-local value of `display-line-numbers'.  Fix bug#73005.

Thank you!






reply via email to

[Prev in Thread] Current Thread [Next in Thread]