bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options


From: john muhl
Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options
Date: Sun, 10 Nov 2024 08:48:39 -0600
User-agent: mu4e 1.12.1; emacs 31.0.50

Eli Zaretskii <eliz@gnu.org> writes:

>> From: john muhl <jm@pub.pink>
>> Cc: 74235@debbugs.gnu.org
>> Date: Sat, 09 Nov 2024 14:54:47 -0600
>> 
>> +  (if (or (not lua-ts-inferior-program)
>> +          (not (executable-find lua-ts-inferior-program)))
>> +      (user-error "You must set `lua-ts-inferior-program' to use this 
>> command")
>
> The text of user-error should say something about being unable to find
> the program, not just about the variable being nil, since you use
> executable-find.
>
> Otherwise, LGTM, thanks.

I guess the executable-find check is redundant anyway since
comint/process will tell you “Searching for program: No such file
or directory, luaz” if you get it wrong.

Thanks again.

Attachment: 0001-Fix-some-lua-ts-mode-options-Bug-74235.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]