[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#77946: master d283db57733: Fix window selection after log-edit-show-
From: |
Eli Zaretskii |
Subject: |
bug#77946: master d283db57733: Fix window selection after log-edit-show-diff, again |
Date: |
Sun, 20 Apr 2025 22:22:54 +0300 |
> Cc: Sean Whitton <spwhitton@spwhitton.name>
> From: Juri Linkov <juri@linkov.net>
> Date: Sun, 20 Apr 2025 20:53:00 +0300
>
> > diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el
> > index 0da0b90975c..3c3288777c8 100644
> > --- a/lisp/vc/log-edit.el
> > +++ b/lisp/vc/log-edit.el
> > @@ -857,7 +857,8 @@ vc-log-fileset
> > (defun log-edit-diff-fileset ()
> > "Display diffs for the files to be committed."
> > (interactive)
> > - (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset)))
> > + (save-selected-window
> > + (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset))))
>
> This change broke the command 'log-edit-show-diff' ('C-c C-d').
> Previously it selected the diff window. Now it always stays in the vc-log
> window.
Isn't it a bug in log-edit-show-diff? Why does it assume that it will
be put in the diff window? It should instead switch there.