[bug-gnu-libiconv] Re: iconv patch to fix compilation issues on win32 with version 1.11

[Bruno Haible]

Hello,

Baptiste Lepilleur wrote:
> I'm not sure you are the right person I should send this to, but I can not 
> find any other contact to contribute my patch.

I am the right person; you could also have sent it to the bug-gnu-libiconv
mailing list.

> The attached patch fix the following issues I run into when attempt to 
> compile libiconv 1.11 on windows with msvc 7.1:
> - added width.c to makefile
> - added simple stdint.h for windows

Thanks for the patch. But on the way to libiconv 1.12 the support for
'nmake' has been dropped. Instead, the build infrastructure consists of
Unix Makefiles for all platforms, and assumes some unixy environment; on
Woe32 you can use Cygwin or mingw for this purpose. Also, you will need
a compiler "driver" that understands the Unix options for compilers (-c,
-o etc.); some people use a script like [1] or the attached one. Try to build
the library statically; building shared libraries on Woe32 with compilers
other than gcc is currently not supported by libtool (see [2]).

The unistd.h and stdint.h will then be created by Makefile rules.

> - worked around EXEEXT compilation issues with msvc71.

> +#if defined _WIN32 && !defined __CYGWIN__
> +# define EXEEXT ".exe"
> +#endif

This looks ok, but again will be done by Makefile rules with the new
build system.

> +#if defined _WIN32 && !defined __CYGWIN__
>      const size_t exeext_len = sizeof (EXEEXT) - sizeof ("");
> +#else
> +    const size_t exeext_len = strlen(EXEEXT);   // above expression does not 
> compile on msvc71
> +#endif

This looks like a no-op change.

Bruno

[1] http://cccl.sourceforge.net/
[2] http://lists.gnu.org/archive/html/libtool/2006-06/msg00037.html

cccl2
Description: application/shellscript