Re: [bug-gnu-libiconv] './check-stateless . ASCII' error during 'make check' run for MSVC builds on Windows

[sav_ix]

I see. Although odd, that it affect shared builds only. For static builds with '-DUNICODE' definition all tests finishes successfully.


Alexander

 

--- Исходное сообщение ---
От кого: "Bruno Haible" <address@hidden>
Дата: 24 апреля 2017, 01:24:55

Hi Alexander,

> ./check-stateless . ASCII 
> make[1]: *** [Makefile:32: check] Error 127 

Such iconv binaries are completely broken.

> Reproduced for <ICC|MSVC><Debug|Release><Shared> builds only, if CFLAGS variable contain key ' -DUNICODE '.

Sure: -DUNICODE changes many prototypes in the <windows.h> headers,
to use wchar_t* strings instead of char* strings. It is absolutely normal
that you get garbage when trying a Unix program with this flag.

> Not sure whether it's an error of <ICC|MSVC> or a flaw in libiconv testsuite.
> But ' -DUNICODE ' is a default key for MESA, QT and other libraries builds
> using MSVC. Would be nice to use it for libiconv too. This allow to make
> builds of all this libraries with the same build options. 

Request denied. Please learn what -DUNICODE means and why it was terribly silly
by Microsoft to introduce this option.