[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

PSPP-BUG: [bug #18860] Need a quoting function and/or conversion .

From: John Darrington
Subject: PSPP-BUG: [bug #18860] Need a quoting function and/or conversion .
Date: Sat, 17 Feb 2007 08:05:33 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20061205 Iceweasel/ (Debian-

Follow-up Comment #4, bug #18860 (project pspp):

  Could the function named "quote" be renamed? It conflicts with   the
"quote" function in gnulib, which although we don't use now we will probably
want to use in the future.

OK.  Do you have any suggestions?

 The following:
 /* Copy the quoted string into str */ ds_destroy (str);   ds_init_string
(str, &quoted_str); ds_destroy (&quoted_str);

 can be simplified into:
 ds_swap (str, &quoted_str); ds_destroy (&quoted_str);

 and it'll avoid copying data to boot.

OK.  Thanks.

 What reason do you foresee for wanting to escape '%'s? To me this option
just looks like a bad idea. It seems to encourage the idea of passing user
data as part of the format string to printf and friends, and I can't say I
like to encourage that.

I did this as I thought it would help with a %sq printf conversion that I was
working on.  But it didn't work out.  Maybe you're right; I should just delete
it.  It'd be simple to put it back again if I need it.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]