PSPP-BUG: [bug #21061] Inserting a variable confuses the dictionary on save.

[Ben Pfaff]

Follow-up Comment #3, bug #21061 (project pspp):

>The problem is that first it calls dict_clone. Unfortunately 
>dict_clone doesn't preserve case indices. Consequently, the 
>case_map is all wrong. 

A patch set that I produced for bug #6117 was supposed to do that.  Somehow
it never got checked in, even though the rest of the patch set seems to have
been.  I'm attaching the missing patch here.

I didn't analyze why your patch causes assertion failures in some tests. 
Mine doesn't, and it still fixes the problem.  What do you think of it?

BTW, I reviewed our current usages of dict_clone and it looks like it isn't
necessary to insert any dict_compact_values calls to comply with the
suggestion in the comment that this patch adds.

(file #13938)
    _______________________________________________________

Additional Item Attachment:

File name: clone-preserve-case-indexes.patch Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?21061>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/