PSPP-BUG: [bug #21108] crashing after bad input program

[Ben Pfaff]

Update of bug #21108 (project pspp):

                  Status:                    None => Ready for Test/Review  

    _______________________________________________________

Follow-up Comment #1:

The problem is this: DATA LIST is looking for BEGIN DATA...END DATA.  Not
seeing it, it terminates the active file and reports an error.  The assertion
failure occurs when DESCRIPTIVES, in calc_descriptives, tries to call
casereader_peek, which fails, and then returns without destroying the
casereader.  This particular casereader is actually the active file.  Since
the active file hasn't been closed when proc_commit tries to verify that it
has been, the assertion fails.

The fix is to always destroy the casereader in calc_descriptives, even if the
call to casereader_peek fails.  The attached patch does this, plus the same
thing for several other procedures that shared the problem.  Actually, trying
to run a procedure with an empty active file would be a good test in general.

(file #13989)
    _______________________________________________________

Additional Item Attachment:

File name: input-program-crash.patch      Size:3 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?21108>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/