[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

PSPP-BUG: [bug #21280] gui truncates system files.

From: Ben Pfaff
Subject: PSPP-BUG: [bug #21280] gui truncates system files.
Date: Fri, 02 Nov 2007 05:54:07 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20061205 Iceweasel/ (Debian-

Update of bug #21280 (project pspp):

                  Status:             In Progress => Ready for Test/Review  


Follow-up Comment #13:

OK, at long last, here is what should be a real fix.

The first patch, overwrite-input-file-allow.patch, is the straightforward
part: make reading and writing separate for locking and do atomic replacement
of files.

Unfortunately, this doesn't really work, because the file handle architecture
is based on inode number, with the assumption that a file won't get deleted
and then a new file created under a different name with the same inode number.
 This is a bad assumption, and at least on my system with an ext3 file system
it causes the match-files.sh test to consistently fail.

Thus, the second patch and much larger patch,
patches/identity-stability.patch, becomes necessary.  In this patch, we drop
the association between a file handle and an inode number.  Instead, a file
handle just represents a file name, and we do inode number lookup and locking
on-demand using a separate table of new "struct fh_lock" structures.  This
fixes the problem and allows everything to pass.


(file #14275, file #14276)

Additional Item Attachment:

File name: overwrite-input-file-allow.patch Size:35 KB
File name: identity-stability.patch       Size:63 KB


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]