PSPP-BUG: [bug #21280] gui truncates system files.

[Ben Pfaff]

Update of bug #21280 (project pspp):

                  Status:             In Progress => Ready for Test/Review  

    _______________________________________________________

Follow-up Comment #13:

OK, at long last, here is what should be a real fix.

The first patch, overwrite-input-file-allow.patch, is the straightforward
part: make reading and writing separate for locking and do atomic replacement
of files.

Unfortunately, this doesn't really work, because the file handle architecture
is based on inode number, with the assumption that a file won't get deleted
and then a new file created under a different name with the same inode number.
 This is a bad assumption, and at least on my system with an ext3 file system
it causes the match-files.sh test to consistently fail.

Thus, the second patch and much larger patch,
patches/identity-stability.patch, becomes necessary.  In this patch, we drop
the association between a file handle and an inode number.  Instead, a file
handle just represents a file name, and we do inode number lookup and locking
on-demand using a separate table of new "struct fh_lock" structures.  This
fixes the problem and allows everything to pass.

Comments?

(file #14275, file #14276)
    _______________________________________________________

Additional Item Attachment:

File name: overwrite-input-file-allow.patch Size:35 KB
File name: identity-stability.patch       Size:63 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?21280>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/