[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

PSPP-BUG: [bug #23263] Shouldn't need GSL for isinf, isnan, and finite

From: Ben Pfaff
Subject: PSPP-BUG: [bug #23263] Shouldn't need GSL for isinf, isnan, and finite
Date: Sun, 27 Jul 2008 18:12:15 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20061205 Iceweasel/ (Debian-

Update of bug #23263 (project pspp):

                  Status:                    None => Ready for Test/Review  


Follow-up Comment #4:

Here is a patch that integrates the new gnulib modules into PSPP, changing it
back to use the standard C99 functions.


    Use standard C99 isfinite, isnan, isinf in place of GSL substitutes.
    In change a9afcdd22, "Use gsl_isnan instead of isnan, ...," isfinite,
    isnan, and isinf were changed to use the GSL substitutes because of
    lack of portability of the C99 versions.  Now, gnulib has portable
    versions of all of these, so change them back.
    This commit changes calls to gsl_finite() to call isfinite() instead
    of the equivalent finite().  isfinite() is correct here: both
    and finite() return true for NaNs, which is a surprising result given
    that a NaN is definitely not finite, but isfinite() returns false and,
    more importantly, behaves as actually wanted in each place it is used
    in PSPP code.
    This commit requires upgrading gnulib to at least change 5183a0e3c,
    "Add missing dependencies on new m4/exponent[fdl].m4 files," or later,
    and re-running "make -f Smake".

(file #16190)

Additional Item Attachment:

File name: foo.patch                      Size:8 KB


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]