[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

PSPP-BUG: [bug #11975] AGGREGATE should support MEDIAN function

From: Ben Pfaff
Subject: PSPP-BUG: [bug #11975] AGGREGATE should support MEDIAN function
Date: Fri, 19 Sep 2008 03:54:25 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20061205 Iceweasel/ (Debian-

Follow-up Comment #8, bug #11975 (project pspp):

The patch looks good.  A few comments:

* I think that the function dict_get_case_weight() could usefully simplify a
small bit of logic.

* My thought was actually slightly different from what you implemented: I had
the notion that the contents of the while loop that your patch inserts into
initialize_aggregate_info() would actually be put into
accumulate_aggregate_info().  Then there is no additional data pass in
initialize_aggregate_info(), because we use the one that is already happening.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]