[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

PSPP-BUG: [bug #20606] Allow system/portable files on command line

From: Ben Pfaff
Subject: PSPP-BUG: [bug #20606] Allow system/portable files on command line
Date: Tue, 04 Nov 2008 05:44:34 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20061205 Iceweasel/ (Debian-

Follow-up Comment #6, bug #20606 (project pspp):

Shouldn't this add the "argp" module to Smake?

I had to stare at the code for quite a while before I understood it.  I think
that is partly just because argp is somewhat convoluted in design, which in
turn forces convoluted workarounds.  In the end I am not certain that argp is
a win, but I guess I don't really object to it either.

I am not a fan of the command_line_processor_replace_aux function.  I think
that, instead, it would be possible to use a pointer to a pointer.  For me,
that would be easier to understand.

Please don't put __ at the beginning of an identifier
(__SRC_UI_COMMAND_LINE_H), as such identifiers are reserved.

Please capitalize SPSS and PSPP in user strings (e.g. in "PSPPIRE --- A user
interface for pspp" and "Set to `compatible' if you want only to accept spss
compatible syntax").

I think there's a punctuator missing in the string "PSPP A program for
statistical analysis"

I don't entirely understand the grouping.  It looks like, in the terminal ui,
the top level has the terminal as a subgroup, which has two subgroups
underneath it.  This requires adding another level of propagation of aux data,
which is a pain.  Would it be easier to just add the two terminal subgroups
directly under the top level?  Then there would be no need for the additional
level of aux data propagation, I think.  That's if I understand what's going
on, which I might not.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]