PSPP-BUG: Re: AW: Questions on PSPP: thank you

[Michel Boaventura]

Hello Ben,

Sorry about the wait, but I'm trying to compile pspp on linux now,
using gentoo and the mingw crosscompile utils.
The windows version of Mingw is very hard to use and have many bugs,
like the problems with latin chars and the relocatable issue.

Im have a lot of work, because I need to compile everything that pspp
needs to make it work, like gtk,glade,pango,cairo, etc.
And each one of its has its own issues. So far I've able to compile
the pspp.exe, and I believe that soon I will have the psppire.exe.

One advantage is that I can now compile the git's versions, instead of
the last 0.6.1.


bye,

Michel

2009/1/29 Ben Pfaff <address@hidden>:
> Hi Michel.  Some time ago Mario (CC'd) reported to me that the
> PSPP build that you provide at http://www.cecaps.ufmg.br/pspp/
> will sometimes write corrupted .sav files.  Recently he reminded
> me about this.
>
> Recently Mario reminded me about that problem, so I now have a
> patch that might fix the problem, which I'm appending to this
> email.  Michel, can you please try applying this patch,
> rebuilding PSPP with it, and providing the binary to Mario.
> Mario, when Michel gives you that binary, will you please see
> whether it fixes the problem with writing .sav files?
>
> Thanks, everyone!  I'd really like to fix this problem.
>
> diff --git a/src/data/make-file.c b/src/data/make-file.c
> index 807adc5..2162741 100644
> --- a/src/data/make-file.c
> +++ b/src/data/make-file.c
> @@ -185,7 +185,7 @@ replace_file_start (const char *file_name, const char 
> *mode,
>         }
>
>       /* Create file by that name. */
> -      fd = open (rf->tmp_name, O_WRONLY | O_CREAT | O_EXCL, permissions);
> +      fd = open (rf->tmp_name, O_WRONLY | O_CREAT | O_EXCL | O_BINARY, 
> permissions);
>       if (fd >= 0)
>         break;
>       if (errno != EEXIST)
>
>
>
>
> --
> "Writing is easy.
>  All you do is sit in front of a typewriter and open a vein."
> --Walter Smith
>