PSPP-BUG: [bug #36395] src/math/histogram.c:111: adjust_bin_ranges: Assertion `lower_limit * half_bin_width <= min' failed

[Ben Pfaff]

Follow-up Comment #4, bug #36395 (project pspp):

>I think it is safe to remove that particular assertion (although it is
algebraically correct).

Even though it's algebraically correct, Mindaugas demonstrated that it isn't
correct in IEEE floating-point arithmetic.

I'm attaching a commit that would replace most the assertions by an error
message.

I'm happy to use some other method, such as just dropping that assertion or
some of the assertions, if you think that is better.  But assertion failures
are serious problems for users.

>What other reasons do you think would cause it to fail?

I'm looking at this:


  if (max == min)
    {
      msg (MW, _("Not creating histogram because the data contains less than 2
distinct values"));
      return NULL;
    }


Thanks,

Ben.

(file #26969)
    _______________________________________________________

Additional Item Attachment:

File name: 0001-histogram-Replace-assertion-failures-by-errors-for-b.patch
Size:2 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36395>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/