PSPP-BUG: [bug #39366] Regression /save = is wrong when splits are active.

[Ben Pfaff]

Follow-up Comment #5, bug #39366 (project pspp):

I spent a little time reading the code.  I noticed the following:

I think that if the DEPENDENT subcommand is given twice (a user error), then
the variables specified the first time will be silently leaked.

cmd_regression() has two local variables named 'i'.

I don't understand why "struct workspace" has a member 'psw' that is a
dynamically allocated array, because it looks like each element of the array
is used only during processing a single split file group.  That is, I think
that 'psw' could be just a singleton, instead of an array.

I think that fill_all_vars() is wrong: if an absent var follows a not-absent
var, then vars[] will be filled with a gap and there will be a write into
unallocated memory.



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?39366>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/