[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Very useful patch for grep :-)
From: |
Paul Eggert |
Subject: |
Re: Very useful patch for grep :-) |
Date: |
Mon, 2 Apr 2001 10:17:22 -0700 (PDT) |
> From: Stepan Koltsov <address@hidden>
> Date: Mon, 2 Apr 2001 11:36:19 +0400
> I added key -D (or --filename-once), that print "-- filename:"
> instead of "--" with options such as -C.
This sort of behavior sounds useful, but I would just have it be the
default behavior if file names are not being printed and if the user
has not specified the --no-filename option. In other words, you
shouldn't need a new option for it. (Anyway the option name
"--filename-once" is misleading, since it doesn't prevent the file
name from being printed more than once.)
Also, please omit the ":" after the file name: it's not needed.
Finally, please revamp the patch so that it's relative to the latest
GNU grep test version, which you can find in
ftp://alpha.gnu.org/gnu/grep.