[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: diffutils-2.7.4: diff --exclude doesn't work
From: |
Paul Eggert |
Subject: |
Re: diffutils-2.7.4: diff --exclude doesn't work |
Date: |
Mon, 10 Dec 2001 16:19:36 -0800 (PST) |
> From: Bruno Haible <address@hidden>
> Date: Mon, 10 Dec 2001 14:15:40 +0100 (CET)
>
>
> diff-2.7.4 doesn't even call the fnmatch() function at all. The
> reason being that in exclude.c:172 the variable 'matcher' always points
> to fnmatch_no_wildcards (all options values being 0 - there is nowhere code
> to add EXCLUDE_WILDCARDS to options).
Thanks for catching that. The add_exclude interface changed (due to a
change in a non-diffutils program), but I forgot to change the
diffutils code that used the interface.
> I don't understand how you can make such profound modifications to "diff"
> without any testsuite.
It was a typo.
Diffutils has never had a test suite, but adding a test suite is on my
long list of things to do. It'd be nice if someone could help out on this.
(I'm not asking you to do it -- I know you're busy too.)