Re: Fwd: Serious bug in patch with --ifdef option

[Paul Eggert]

> From: Pete Buechler <address@hidden>
> Date: Sun, 5 Nov 2000 20:14:48 -0700
> 
> I found a serious bug in patch when used with unified diffs and the
> --ifdef option. It was using the directive #ifdef on lines that it
> should have printed #ifndef. Enclosed please find a patch to repair
> this.
> 
> While I had patch open, I decided that it was inconsistent for it to
> comment the #endif so that it would be easy to match it to its
> corresponding #ifdef, but not to comment the #else. So I created a
> patch to make it comment both. I have kept the patches separate so that
> you can accept one without the other more easily.

Thanks for your bug report and fix.  I decided that it was better to
omit the comments entirely, since POSIX 1003.1-2001 does not seem to
allow them.  You can find a fixed version (finally!) in:

ftp://alpha.gnu.org/gnu/patch/patch-2.5.6.tar.gz