Re: objdump assertion failure

[Alan Modra]

On Sun, Aug 04, 2002 at 07:05:56PM +0300, Sami Kantoluoto wrote:
> I'm getting following message when using "mcore-elf-objdump -g <obj>" on
> some object files:

Happens on i686-linux with gcc-2.95 and current mainline cvs gcc too.

> assertion "info->stack->visibility != DEBUG_VISIBILITY_IGNORE" failed: file
> "/pub/devel/gnu/binutils-2.11.2/binutils/prdbg.c", line 997
> 
> 
> Object file is generated with "mcore-elf-gcc -gstabs+ -o <obj> -c <src>".
> 
> Error can be reproduced using following source:
> 
> /* begin of test.c */
> typedef struct dummy {
>   union {
>     char Data[0];
>     int Error;
>   } D;
> } dummy_t;
> /* end of test.c */

Given that binutils/stabs.c:2548 generates DEBUG_VISIBILITY_IGNORE for
zero length arrays, I think we need to remove the assert.

binutils/ChangeLog
        * prdbg.c (pr_fix_visibility): Remove assert.

Committing mainline.

Index: binutils/prdbg.c
===================================================================
RCS file: /cvs/src/src/binutils/prdbg.c,v
retrieving revision 1.4
diff -u -p -r1.4 prdbg.c
--- binutils/prdbg.c    26 May 2002 14:55:04 -0000      1.4
+++ binutils/prdbg.c    5 Aug 2002 00:51:30 -0000
@@ -992,8 +992,6 @@ pr_fix_visibility (info, visibility)
   if (info->stack->visibility == visibility)
     return true;
 
-  assert (info->stack->visibility != DEBUG_VISIBILITY_IGNORE);
-
   switch (visibility)
     {
     case DEBUG_VISIBILITY_PUBLIC:

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre