[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] Objdump disassembly with dynamic relocation info
From: |
Nick Clifton |
Subject: |
Re: [Patch] Objdump disassembly with dynamic relocation info |
Date: |
09 Aug 2002 16:56:24 +0100 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 |
Hi Dirk,
> this is a patch against binutils 2.12.90.0.1 (from the woody debian
> source package) to make objdump disassembly work better with dynamic
> relocation information.
Thanks very much for submitting this patch. It certainly looks very
useful but before we can accept it there are a few points that need to
be addressed:
* You need to have a binutils copyright assignment on file with the
FSF. I am attaching a request form at the end of this email.
* You should follow the GNU coding style when adding new code to the
binutils project. For example:
if ((sym->flags & (BSF_DEBUGGING)) &&
(sym->value == 0) &&
! bfd_is_const_section(sym->section) &&
(sym->name == NULL || sym->name[0] == '\0'))
should be:
if ((sym->flags & (BSF_DEBUGGING))
&& (sym->value == 0)
&& ! bfd_is_const_section (sym->section)
&& (sym->name == NULL || sym->name[0] == '\0'))
There are lots more examples of this kind of thing. I am not
asking for a fanatical adherences to the standard, but using a
consistent style throughout the sources really does help to make
them more readable.
* Please do not include the ChangeLog entry as part of the patch,
(it never applies cleanly). Instead just include it in your email
submission as plain text.
Cheers
Nick
---------------------------------------------------------------------------
request-assign.future:
Please email the following information to address@hidden, and we
will send you the assignment form for your past and future changes.
Please use your full name as the subject line of the message.
[What is the name of the program or package you're contributing to?]
[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]
[Do you have an employer who might have a basis to claim to own
your changes? Do you attend a school which might make such a claim?]
[For the copyright registration, what country are you a citizen of?]
[What year were you born?]
[Please write your email address here.]
[Please write your snail address here.]
[Which files have you changed so far, and which new files have you written
so far?]
---------------------------------------------------------------------------