Re: Was having a crash with 2.13/CVS ld; this change has fixed it

[Nicholas Adrian Vinen]

   Hmm, well, you may be right, but I had more than one crash before this
change and none since, so it fixed something, whether it's the right
change or not. The symptoms were very much like something overrunning its
memory bounds (the SEGV was usually in realloc()).

     Nicholas

On Sat, 26 Oct 2002, Alan Modra wrote:

> On Sat, Oct 26, 2002 at 06:50:19AM +0000, Nicholas Adrian Vinen wrote:
> >
> > bfd/elflink.h:
> > 8144c8144
> > <       bytes = (size / file_align + 1) * sizeof (boolean);
> > ---
> > >       bytes = (size / file_align + 2) * sizeof (boolean);
> >
> >    The realloc a few lines below was crashing. Perhaps the memory block
> > was trashed past the end? Since the ptr is stored as ptr-1, perhaps the
> > extra +1 is needed to make up for it (the other +1 is because if you
> > want to index data at 7, you need 8 bytes...)
>
> No, the code as is looks correct to me.  I think it more likely
> that there's some sort of problem with elf_gc_record_vtentry's
> arguments, probably "addend".
>
> --
> Alan Modra
> IBM OzLabs - Linux Technology Centre
>