Re: A segfault in bfd/format.c

[Nick Clifton]

Hi Bernd,

> Here is a segfault in i386-mingw32-dlltool from (linux)
> binutils-2.13.90.0.20 with neither of my 2 patches anywhere near bfd
> itself.  (The patches don't affect this configuration.)  100%
> reproducible for me

Thak you for reporting this bug.  Please try the patch attached
below, which I think should fix the problem.

Cheers
        Nick

bfd/ChangeLog
2003-04-18  Nick Clifton  <address@hidden>

        * format.c (bfd_check_format_matches): Only check associated
        vector if the matching_vector has been created.

Index: bfd/format.c
===================================================================
RCS file: /cvs/src/src/bfd/format.c,v
retrieving revision 1.13
diff -c -3 -p -w -r1.13 format.c
*** bfd/format.c        31 Mar 2003 18:13:25 -0000      1.13
--- bfd/format.c        18 Apr 2003 08:01:06 -0000
*************** bfd_check_format_matches (abfd, format, 
*** 305,311 ****
        }
      }
  
!   if (match_count > 1 && bfd_associated_vector != NULL)
      {
        const bfd_target * const *assoc = bfd_associated_vector;
  
--- 305,313 ----
        }
      }
  
!   if (match_count > 1
!       && bfd_associated_vector != NULL
!       && matching)
      {
        const bfd_target * const *assoc = bfd_associated_vector;