[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Grep --directories option
From: |
Stepan Kasal |
Subject: |
Re: Grep --directories option |
Date: |
Wed, 4 Jun 2003 07:51:29 +0200 |
User-agent: |
Mutt/1.2.5.1i |
Hello,
On Tue, Jun 03, 2003 at 02:57:09PM -0400, Alain Magloire wrote:
> > [1] grep 2.5 introduced a bug, which effectively changed the code
> >
> > if (! fillbuf (save, stats))
> > if (! (is_EISDIR (errno, file) && suppress_errors))
> > error (filename, errno);
> >
> > to
> >
> > if (! fillbuf (save, stats))
> > if (! is_EISDIR (errno, file) && ! suppress_errors)
> > error (filename, errno);
> Where is that code, out of curiousity I've downloaded 2.5 and 2.5.1
file grep.c, function grep().
Well, I tried to make the long story short.
In 2.5, suppressible_error() was introduced.
So the new code actually looks like
if (! fillbuf (save, stats))
{
if (! is_EISDIR (errno, file))
suppressible_error (filename, errno);
return 0;
}
I was under the impression that the programmer thought that this was
an equivalent change.
Sorry for the confusion,
Stepan Kasal