bug-gnu-utils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

make DESTDIR=foobar is not honoured in grep-2.5/src/Makefile.in


From: Roberto Nibali
Subject: make DESTDIR=foobar is not honoured in grep-2.5/src/Makefile.in
Date: Wed, 16 Jun 2004 15:53:33 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007

Hello,

[I'm not subscribed, so please cc to all addresses if you need feedback]

Working in a somewhat special development environment we do need the 'make DESTDIR=foobar install' combo. This worked fine for grep-2.4.2 since egrep and fgrep were binaries as opposed to grep-2.5 where they ended up being symlinks and implicitly generated the need for another Makefile target.

To cut a long story short; the following patch addresses the problem in a rigorous way:

--- grep-2.5-uclibc/src/Makefile.in     2004-06-16 07:44:04.000000000 -0600
+++ grep-2.5-uclibc-fixed/src/Makefile.in       2004-06-16 07:09:21.000000000 
-0600
@@ -354,8 +354,8 @@


 install-exec-local:
-       @SYMLINK@ @SYMLINKFROM@ $(bindir)/egrep
-       @SYMLINK@ @SYMLINKFROM@ $(bindir)/fgrep
+       @SYMLINK@ @SYMLINKFROM@ $(DESTDIR)$(bindir)/egrep
+       @SYMLINK@ @SYMLINKFROM@ $(DESTDIR)$(bindir)/fgrep
 # Tell versions [3.59,3.63) of GNU make to not export all variables.
 # Otherwise a system limit (for SysV at least) may be exceeded.
 .NOEXPORT:

I have not checked other occurences of other such issues in the source tree and I haven't checked with the cvs either since I do not have access to cvs from where I work. Please consider this patchlet for inclusion into the next release of GNU/grep. It's tested with DESTDIR unset, DESTDIR= and with DESTDIR=foobar.

Best regards,
Roberto Nibali, ratz
--
-------------------------------------------------------------
addr://Rathausgasse 31, CH-5001 Aarau  tel://++41 62 823 9355
http://www.terreactive.com             fax://++41 62 823 9356
-------------------------------------------------------------
terreActive AG                       Wir sichern Ihren Erfolg
-------------------------------------------------------------





reply via email to

[Prev in Thread] Current Thread [Next in Thread]