Re: [PATCH] Permit user to select keys when using sdiff merge

[Chuck Swiger]

Paul Eggert wrote:
> Chuck Swiger <address@hidden> writes:
> > However, the person who made the initial feature request wanted
> > different keys.
>
> Which ones?  Perhaps we could add them too.

Justin Settle <address@hidden> wanted 'f' and 'j', as the "home 
row keys"-- others preferred '1' & '2'; 'g' & 'd'; or ',' & '.'; and one 
person even asked to use the left and right arrow keys.

> > I think a solution that lets the user select their preferred keys
>  
> True, but there are tradeoffs here; we can't shoehorn every requested
> feature in.

I don't understand this concern:

13-sec% wc -l sdiff.c_orig sdiff.c
    1109 sdiff.c_orig
    1082 sdiff.c

The patch implements the feature a number of users requested, and the 
resulting code is 27 lines smaller than the original code.

However, the people who really wanted to pick their own keys have already 
given the patch I wrote a spin, so whether the change is adopted into the 
FreeBSD version of sdiff, or whether it gets adopted into the vendor branch, 
is not as important to me.

> > I suppose that's up to Tom Lord or whoever is maintaining diffutils ...
>
> That's me.

OK.  Well, I'd be happy to make changes to the patch in response to your 
comments or concerns, but, by the same token, you need to give me something 
more specific to work with.

--
-Chuck