[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: do not grep config.status internals
From: |
Bruno Haible |
Subject: |
Re: do not grep config.status internals |
Date: |
Sat, 16 Dec 2006 17:57:24 +0100 |
User-agent: |
KMail/1.9.1 |
Ralf Wildenhues wrote:
> YOU DON'T grep config.status! That NEVER worked reliably, and that was
> NEVER documented.
It was too tempting - since the structure of config.status stayed the same
for 14 years.
> Here's an example from the gettext package.
Thanks, I applying this simpler patch:
2006-12-16 Bruno Haible <address@hidden>
Make it work with autoconf > 2.61.
* Makefile.am (TESTS_ENVIRONMENT): Also set GLIBC2.
* gettext-3: Use GLIBC2 from the environment instead of grepping
config.status.
* gettext-5: Likewise.
* gettext-6: Likewise.
* gettext-7: Likewise.
Reported by Ralf Wildenhues.
*** Makefile.am 12 Dec 2006 14:12:18 -0000 1.91
--- Makefile.am 16 Dec 2006 16:58:06 -0000
***************
*** 171,176 ****
--- 171,177 ----
BUILDCSHARP='@BUILDCSHARP@' \
TESTCSHARP='@TESTCSHARP@' \
TESTLIBASPRINTF='@TESTLIBASPRINTF@' \
+ GLIBC2='@GLIBC2@' \
LOCALE_FR='@LOCALE_FR@' \
LOCALE_FR_UTF8='@LOCALE_FR_UTF8@' \
LOCALE_JA='@LOCALE_JA@' \
*** gettext-3 9 Jun 2006 20:22:17 -0000 1.2
--- gettext-3 16 Dec 2006 16:58:06 -0000
***************
*** 7,13 ****
trap 'rm -fr $tmpfiles' 1 2 3 15
# This test works only on glibc systems.
! grep '@address@hidden' ../config.status >/dev/null || {
echo "Skipping test: not a glibc system"
exit 77
}
--- 7,14 ----
trap 'rm -fr $tmpfiles' 1 2 3 15
# This test works only on glibc systems.
! : ${GLIBC2=no}
! test "$GLIBC2" = yes || {
echo "Skipping test: not a glibc system"
exit 77
}
*** gettext-5 9 Jun 2006 20:22:17 -0000 1.2
--- gettext-5 16 Dec 2006 16:58:06 -0000
***************
*** 7,13 ****
trap 'rm -fr $tmpfiles' 1 2 3 15
# This test works only on glibc systems.
! grep '@address@hidden' ../config.status >/dev/null || {
echo "Skipping test: not a glibc system"
exit 77
}
--- 7,14 ----
trap 'rm -fr $tmpfiles' 1 2 3 15
# This test works only on glibc systems.
! : ${GLIBC2=no}
! test "$GLIBC2" = yes || {
echo "Skipping test: not a glibc system"
exit 77
}
*** gettext-6 21 Jul 2006 12:23:33 -0000 1.3
--- gettext-6 16 Dec 2006 16:58:06 -0000
***************
*** 8,14 ****
trap 'rm -fr $tmpfiles' 1 2 3 15
# This test works only on glibc systems.
! grep '@address@hidden' ../config.status >/dev/null || {
echo "Skipping test: not a glibc system"
exit 77
}
--- 8,15 ----
trap 'rm -fr $tmpfiles' 1 2 3 15
# This test works only on glibc systems.
! : ${GLIBC2=no}
! test "$GLIBC2" = yes || {
echo "Skipping test: not a glibc system"
exit 77
}
*** gettext-7 21 Jul 2006 12:23:33 -0000 1.3
--- gettext-7 16 Dec 2006 16:58:06 -0000
***************
*** 8,14 ****
trap 'rm -fr $tmpfiles' 1 2 3 15
# This test works only on glibc systems.
! grep '@address@hidden' ../config.status >/dev/null || {
echo "Skipping test: not a glibc system"
exit 77
}
--- 8,15 ----
trap 'rm -fr $tmpfiles' 1 2 3 15
# This test works only on glibc systems.
! : ${GLIBC2=no}
! test "$GLIBC2" = yes || {
echo "Skipping test: not a glibc system"
exit 77
}