gettext: -lacl needed for libgettextlib.la

[Ralf Wildenhues]

Hello Bruno, all,

On Debian GNU/Linux, this happens with CVS gettext:

$ /bin/sh ../libtool --tag=CC   --mode=link gcc  -g -O2   -o test-names 
test-names.o libuniname.a ../gnulib-lib/libgettextlib.la
| gcc -g -O2 -o .libs/test-names test-names.o  libuniname.a 
../gnulib-lib/.libs/libgettextlib.so -lc -lncurses -Wl,--rpath 
-Wl,/home/ralf/local/lib
| ../gnulib-lib/.libs/libgettextlib.so: undefined reference to `acl_entries'
| ../gnulib-lib/.libs/libgettextlib.so: undefined reference to `acl_get_file'
| ../gnulib-lib/.libs/libgettextlib.so: undefined reference to `acl_set_file'
| ../gnulib-lib/.libs/libgettextlib.so: undefined reference to 
`acl_delete_def_file'
| ../gnulib-lib/.libs/libgettextlib.so: undefined reference to `acl_get_fd'
| ../gnulib-lib/.libs/libgettextlib.so: undefined reference to `acl_set_fd'
| ../gnulib-lib/.libs/libgettextlib.so: undefined reference to `acl_free'
| ../gnulib-lib/.libs/libgettextlib.so: undefined reference to `acl_from_mode'
| ../gnulib-lib/.libs/libgettextlib.so: undefined reference to 
`acl_extended_file'
| collect2: ld returned 1 exit status

The patch below fixes the issue for me, with:

cd gettext-tools
./libtool --mode=clean rm -f gnulib-lib/libgettextlib.la
make

While looking into this, I noticed a couple of tests that weren't using
$LIBS, but where adding that would help for a
  make LIBS=...

workaround; see the second part of the patch.

Cheers,
Ralf

gettext-tools/ChangeLog:
2007-01-31  Ralf Wildenhues  <address@hidden>

        * gnulib-lib/Makefile.am (libgettextlib_la_LIBADD): Add
        $(LIB_ACL).

gettext-tools/tests/ChangeLog:
2007-01-31  Ralf Wildenhues  <address@hidden>

        * lang-c: Add $LIBS while linking.
        * lang-c++: Likewise.

Index: gettext-tools/gnulib-lib/Makefile.am
===================================================================
RCS file: /cvsroot/gettext/gettext/gettext-tools/gnulib-lib/Makefile.am,v
retrieving revision 1.3
diff -u -r1.3 Makefile.am
--- gettext-tools/gnulib-lib/Makefile.am        23 Dec 2006 16:03:51 -0000      
1.3
+++ gettext-tools/gnulib-lib/Makefile.am        31 Jan 2007 19:48:05 -0000
@@ -74,3 +74,4 @@
        -o $@
 endif
 
+libgettextlib_la_LIBADD += $(LIB_ACL)
cvs diff: Diffing gettext-tools/tests
Index: gettext-tools/tests/lang-c
===================================================================
RCS file: /cvsroot/gettext/gettext/gettext-tools/tests/lang-c,v
retrieving revision 1.9
diff -u -r1.9 lang-c
--- gettext-tools/tests/lang-c  2 Aug 2006 16:12:44 -0000       1.9
+++ gettext-tools/tests/lang-c  31 Jan 2007 19:48:05 -0000
@@ -49,7 +49,7 @@
 # Put the -I flags before ${CFLAGS} ${CPPFLAGS}, to make sure that libintl.h
 # is found in the build directory, regardless of -I options present in
 # ${CFLAGS} or ${CPPFLAGS}.
-${LIBTOOL} --quiet --mode=link ${CC} -I.. -I$top_srcdir/gnulib-lib 
../gnulib-lib/libgettextlib.la -I../intl ${CFLAGS} ${CPPFLAGS} ${LDFLAGS} -o 
prog prog.c ${LTLIBINTL} \
+${LIBTOOL} --quiet --mode=link ${CC} -I.. -I$top_srcdir/gnulib-lib 
../gnulib-lib/libgettextlib.la -I../intl ${CFLAGS} ${CPPFLAGS} ${LDFLAGS} -o 
prog prog.c ${LTLIBINTL}  ${LIBS} \
   || exit 1
 
 tmpfiles="$tmpfiles prog.pot"
Index: gettext-tools/tests/lang-c++
===================================================================
RCS file: /cvsroot/gettext/gettext/gettext-tools/tests/lang-c++,v
retrieving revision 1.10
diff -u -r1.10 lang-c++
--- gettext-tools/tests/lang-c++        2 Aug 2006 16:12:44 -0000       1.10
+++ gettext-tools/tests/lang-c++        31 Jan 2007 19:48:05 -0000
@@ -70,7 +70,7 @@
 # ${CXXFLAGS} or ${CPPFLAGS}.
 ${CXX} -I.. -I../../gettext-runtime/libasprintf -I$top_srcdir/gnulib-lib 
-I../intl ${CXXFLAGS} ${CPPFLAGS} -c prog.cc \
   || exit 1
-${LIBTOOL} --quiet --mode=link ${CXX} ${CXXFLAGS} ${LDFLAGS} -o prog 
prog.${OBJEXT} ../../gettext-runtime/libasprintf/libasprintf.la 
../gnulib-lib/libgettextlib.la ${LTLIBINTL} \
+${LIBTOOL} --quiet --mode=link ${CXX} ${CXXFLAGS} ${LDFLAGS} -o prog 
prog.${OBJEXT} ../../gettext-runtime/libasprintf/libasprintf.la 
../gnulib-lib/libgettextlib.la ${LTLIBINTL} ${LIBS} \
   || exit 1
 
 tmpfiles="$tmpfiles prog.pot"