bug-gnu-utils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Avoid unportable nested double-quotes and backquotes.


From: Ralf Wildenhues
Subject: Avoid unportable nested double-quotes and backquotes.
Date: Sun, 23 May 2010 09:49:51 +0200
User-agent: Mutt/1.5.20 (2009-10-28)

Hi Bruno,

noticed this small shell unportability in gnulib coming from gettext.

Cheers,
Ralf

2010-05-23  Ralf Wildenhues  <address@hidden>

        Avoid unportable nested double-quotes and backquotes.
        * gettext-runtime/m4/po.m4 (AM_PO_SUBDIRS)
        (AM_POSTPROCESS_PO_MAKEFILE): Remove unportable and unneeded
        outer double-quotes in shell variable assignment.

diff --git a/gettext-runtime/m4/po.m4 b/gettext-runtime/m4/po.m4
index 47f36a4..c39452c 100644
--- a/gettext-runtime/m4/po.m4
+++ b/gettext-runtime/m4/po.m4
@@ -1,4 +1,4 @@
-# po.m4 serial 17 (gettext-0.18)
+# po.m4 serial 18 (gettext-0.18)
 dnl Copyright (C) 1995-2010 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -102,7 +102,7 @@ changequote([,])dnl
       case "$ac_file" in */Makefile.in)
         # Adjust a relative srcdir.
         ac_dir=`echo "$ac_file"|sed 's%/[^/][^/]*$%%'`
-        ac_dir_suffix="/`echo "$ac_dir"|sed 's%^\./%%'`"
+        ac_dir_suffix=/`echo "$ac_dir"|sed 's%^\./%%'`
         ac_dots=`echo "$ac_dir_suffix"|sed 's%/[^/]*%../%g'`
         # In autoconf-2.13 it is called $ac_given_srcdir.
         # In autoconf-2.50 it is called $srcdir.
@@ -226,7 +226,7 @@ AC_DEFUN([AM_POSTPROCESS_PO_MAKEFILE],
 changequote(,)dnl
   # Adjust a relative srcdir.
   ac_dir=`echo "$ac_file"|sed 's%/[^/][^/]*$%%'`
-  ac_dir_suffix="/`echo "$ac_dir"|sed 's%^\./%%'`"
+  ac_dir_suffix=/`echo "$ac_dir"|sed 's%^\./%%'`
   ac_dots=`echo "$ac_dir_suffix"|sed 's%/[^/]*%../%g'`
   # In autoconf-2.13 it is called $ac_given_srcdir.
   # In autoconf-2.50 it is called $srcdir.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]