RE: archive generated by shar -V does not support the -c option]

[Bruce Korb]

On Fri, Aug 27, 2010 at 4:22 PM, Karl Berry <address@hidden> wrote:
> Just to be sure you see this ...

Thanks -- I did miss it.

> Date: Fri, 27 Aug 2010 10:35:07 +0200
> From: Paolo Bonzini <address@hidden>
> To: address@hidden
> Subject: archive generated by shar -V does not support the -c option
>
> When generating an archive with "shar -V", the output of shar mentions
> "$first_param" without ever assigning to it.
>
> Probably it should be changed to "$1", or a "first_param=$1" statement
> should be introduced somewhere to minimize differences with non-vanilla
> shell archives.

"first_param" makes it a bit difficult to tell what it is all about.
I am adding this text to all shar archives:

        test "X$1" = "X-c" && keep_file=false || keep_file=true

so 'keep_file' will be set whether i18n is disabled or not.
It is used thus:

   if test -f 'shar-1.in' && ${keep_file}; then
   ${echo} "x - SKIPPING shar-1.in (file already exists)"
   else [...]