|
From: | Jose E. Marchesi |
Subject: | Re: GNU sed maintainers, please document GNU sed's "-E" option (which is now in POSIX) |
Date: | Tue, 15 Oct 2013 21:17:42 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Hi David. Thank you for submitting the patch. Given that -E has been added to POSIX I see nothing wrong on documenting -E along with -r. Could you please provide a ChangeLog entry documenting the changes? Also, +usually have less backslashes. Please replace `less backslashes' with `fewer backslashes' as Bruce suggested. - /* Undocumented, for compatibility with BSD sed. */ + /* "-E" is in POSIX, http://austingroupbugs.net/view.php?id=528 */ case 'E': case 'r': if (extended_regexp_flags) That comment about -E being in POSIX is unnecessary. Just remove the comment claiming that -E is not documented. Would you like to update your patch and resend it using git format-patch? Thanks :)
[Prev in Thread] | Current Thread | [Next in Thread] |