Re: [sharutils] Does not compile with -fno-common

[Bruce Korb]

On 1/23/20 7:19 AM, Petr Pisar wrote:
> On Mon, Jan 20, 2020 at 07:47:15PM +0100, Christian Voegl wrote:
>> Trying to build sharutils 4.15.2 with  -fno-common fails with
>>
>>    [   30s]
>>    /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld:
>>    shar-opts.o:(.data.rel.ro.local+0x0): multiple definition of
>>    `program_name'; shar.o:(.rodata+0x10): first defined here
>>    [   30s]
>>    /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld:
>>    ../lib/libgnu.a(md5.o): in function `md5_stream':
>>    [   30s] md5.c:(.text+0x15d): multiple definition of `md5_stream';
>>    shar.o:shar.c:(.text+0x28): first defined here
>>
>>
>> As -fno-common is going to be the default, I think this should be fixed.
>>
> Please try the two patches attached. The first one should fix the program_name
> symbol. The second the md5_stream symbol. I was able to reproduce the first
> one, but not the second one. (Depiste tha fact I do not link to openssl.)
> 
> -- Petr

Thank you guys. I'll queue this up for when I can figure out how to
re-run "autoreconf" once again. Meanwhile, use Petr's patch.