Re: [Bug-gnubg] Bug in command line mode

[Joern Thyssen]

Hi again,

On Thu, Aug 22, 2002 at 07:35:42AM +0000, Joern Thyssen wrote
> Hi Sander,
> 
> On Thu, Aug 22, 2002 at 03:47:50AM +0200, Sander van Rijnswou wrote
[snip]
> > Gtk-WARNING **: invalid cast from (NULL) pointer to `Board'
> > Segmentation fault
> 
> Which snapshot do you use?
> 
> I'll look at it tonight. I have a feeling what's wrong:
> 
> gnubg.c, line 2875ff:
> 
> 2875: #if USE_GTK
> 2876:         fHasMoved = GTKGetMove ( anMove );
> 2877:         if ( fHasMoved )
> 2878:           MoveKey ( ms.anBoard, anMove, auch );
> 2879: #else
> 2880:         fHasMoved = FALSE;
> 2881: #endif /* ! USE_GTK */
> 2882: 
> 
> should probably be (untested):
> 
> 2875: #if USE_GTK
>               if ( fX ) {
> 2876:            fHasMoved = GTKGetMove ( anMove );
> 2877:            if ( fHasMoved )
> 2878:              MoveKey ( ms.anBoard, anMove, auch );
>               }
>               else
>                 fHasMoved = FALSE;
> 2879: #else
> 2880:         fHasMoved = FALSE;
> 2881: #endif /* ! USE_GTK */
> 2882: 

I've commited the patch. 

Please download the next build, or update via CVS.

Jørn

-- 
Joern Thyssen, PhD
Vendsysselgade 3, 3., DK-9000 Aalborg, Denmark
+45 9813 2791 (private) / +45 2077 2689 (mobile) / +45 9633 7036 (work)