[Bug-gnubg] Some compiling problems and warnings

[Øystein O Johansen]

Hi all!

I have just changed to mingw-2.0 and thereby gcc-3.2 for compiling windows
executables. I get some problems and I have to make some changes to the
code before it compiles decently.

First: I get a lot of warnings in analysis.c:

analysis.c: In function `DumpStatcontext':
analysis.c:1257: warning: unknown conversion type character `)' in format
analysis.c:1257: warning: unknown conversion type character `)' in format
analysis.c:1257: warning: unknown conversion type character `)' in format
analysis.c:1257: warning: unknown conversion type character `)' in format
analysis.c:1305: warning: unknown conversion type character `)' in format
analysis.c:1305: warning: unknown conversion type character `)' in format
analysis.c:1318: warning: unknown conversion type character `)' in format
...
..
.

Jørn? It is the % in the string formatting.

    sprintf ( strchr ( szOutput, 0 ),
              ms.nMatchTo ?
              "%-31s %+6.3f (%+7.3f%%)       %+6.3f (%+7.3f%%)\n"
              "%-31s %+6.3f (%+7.3f%%)       %+6.3f (%+7.3f%%)\n" :
              "%-31s %+6.3f (%+7.3f%)        %+6.3f (%+7.3f%)\n"
              "%-31s %+6.3f (%+7.3f%)        %+6.3f (%+7.3f%)\n",
-----------------------------------^
This shouldn't be here? Should it?

The second problem is the definition of DATADIR in config.h
It's in conflict with a definition of DATADIR in a header
file called objidl.h in mingw/include. This problem is simply
solved by changing the name DATADIR in config.h to DATADIR2.
The name DATADIR is generated form configure, and I will guess
this name conflict wil generate problems for other users as well.
I think we should rename this definition to something else.

-Øystein




-------------------------------------------------------------------
The information contained in this message may be CONFIDENTIAL and is
intended for the addressee only. Any unauthorised use, dissemination of the
information or copying of this message is prohibited. If you are not the
addressee, please notify the sender immediately by return e-mail and delete
this message.
Thank you.