Re: [Bug-gnubg] Stopping Rollout Early Doesn't Update the Hint Window since 24June Build

[Jim Segrave]

On Fri 27 Jun 2003 (17:37 +0000), Joern Thyssen wrote:
> On Thu, Jun 26, 2003 at 06:11:16PM -0400, address@hidden wrote
> > Hi
> > If you stop a rollout before the selected number of trials the hint window 
> > doesn't get updated with the rollout equity anymore.
> 
> This is related to Jim's recent changes to the rollout code:
> 
>   if( ( cGames != i ) && !stopped_early )
>       return -1;
> 
> I'm not sure what the correct behaviour should be.

Yes - I can see the problem

There was a main loop which keeps calling the single game rollout loop

At the end of the loop the original code was:

for (i = 0; i < cGames; i++) {
   roll out a game;
   if (stop button hit)
      break;

   accumulate statistics;
}


if (!(cGames = i))
    return -1;

I have to admit I read that as:

if (!(cGames == i))

and assumed that RolloutGeneral was returning at this point if the
rollout was interrupted. So when I changed the code, I set it to do
that - return -1 immediately if the rollout was interupted.

I'm commiting a fix now (with code that makes it clearer what's
supposed to happen.

-- 
Jim Segrave           address@hidden