Re: [Bug-gnulib] Minor cosmetic fix for gnulib-tool generated Makefile.am

[Derek Robert Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Derek Robert Price wrote:

> Bruno Haible wrote:
>
> >Derek Robert Price wrote:
>
> >>## For module alloca-opt:
> >>BUILT_SOURCES += $(ALLOCA_H)
> >>EXTRA_DIST += alloca_.h
>
>
> >I would prefer this style:
>
>
> ># >>> gnulib module alloca-opt.
>
> >BUILT_SOURCES += $(ALLOCA_H)
> >EXTRA_DIST += alloca_.h
>
> ># <<< gnulib module alloca-opt.
>
>
> >Does this look good to you?
>
>
>
> It's fine with me, except that it should probably use the double-#
> comment which Automake removes when it generates Makefile.in, like so:
>
> ## >>> gnulib module alloca-opt.
>
> BUILT_SOURCES += $(ALLOCA_H)
> EXTRA_DIST += alloca_.h
>
> ## <<< gnulib module alloca-opt.
>
>
> Otherwise, since Automake compiles the += line into a single macro
> definion line and deletes the original += lines, you would have a
> bunch of comments bracketing nothing in the Makefile.in:
>
> # >>> gnulib module alloca.
>
>
> # <<< gnulib module alloca.
>
> # >>> gnulib module alloca-opt.
>
>
> and so on.
>
> This might be more complicated to do in sed too, and still notice and
> skip the empty modules, though I won't know for sure until I try.  I
> do have a second version of my patch which creats a temp file then
> checks it wasn't all white space before it adds the comments and
> copies in the contents of the temp file if you'd like that.  I'll be
> out of town for a few days but if you want it and I can't find a way
> to check my email tonight, I should be able to send it Wednesday or
> Thursday.
>
> Cheers,
>
> Derek


New patch included combining my and Bruno's suggestions.

2004-10-15  Derek R. Price  <address@hidden>

    * gnulib-tool: Cosmetic improvement for installed Makefile.am.

Cheers,

Derek
- --
                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBb01tLD1OTBfyMaQRAnoJAKC4Kk5Vkg/Kr5t2grgYasObz0eKGACeMtWB
ROOEmTDLBol1q6Bcw4CAoN4=
=nWh4
-----END PGP SIGNATURE-----