bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: syncing md5 against glibc


From: Jim Meyering
Subject: Re: syncing md5 against glibc
Date: Tue, 11 Oct 2005 23:31:16 +0200

Simon Josefsson <address@hidden> wrote:
> Let's not wait for glibc to install my patch...  What do you think
> about installing the following in gnulib now?  It would sync gnulib
> with my proposed libc-patch.  It also fixes the sha1 module to be
> standalone.

I like it.  Thanks for the clean-up.
I suppose you've done at least a little portability testing?
A quick glance through the diffs showed only one nit:

> -   IMPORTANT: On some systems it is required that RESBUF be correctly
> +   IMPORTANT: On some systems it is required that RESBUF is correctly
>     aligned for a 32 bits value.  */

Please don't make that change.
Using `be' there is actually correct, but the sentence
should be changed.  How about this instead?

   IMPORTANT: On some systems, RESBUF must be aligned to a 32-bit boundary.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]