[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: test failures: crc, md4, gc-md4
From: |
Simon Josefsson |
Subject: |
Re: test failures: crc, md4, gc-md4 |
Date: |
Wed, 10 May 2006 15:39:50 +0200 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) |
Ralf Wildenhues <address@hidden> writes:
> FYI, a few of the gnulib tests currently fail:
> On x86_64-unknown-linux-gnu (omitting passed tests):
...
> md4 1 mismatch. expected:
> a4 48 01 7a af 21 d8 52 5f c1 0a e8 7a a6 72 9d
> computed:
> 29 e6 63 dd dc 61 52 69 91 85 da 92 ed 96 c8 b1
> FAIL: test-gc-md4
>
> expected:
> a4 48 01 7a af 21 d8 52 5f c1 0a e8 7a a6 72 9d
> computed:
> 29 e6 63 dd dc 61 52 69 91 85 da 92 ed 96 c8 b1
> FAIL: test-md4
Someone reported this for Shishi, and I tracked this down and I
installed the fix below. It wasn't easy to spot this...
2006-05-10 Simon Josefsson <address@hidden>
* md4.c: Typo fix, update copyright years.
(K1, K2): Don't use L because it turn computations into 64-bit on
64-bit platforms.
Index: md4.c
===================================================================
RCS file: /sources/gnulib/gnulib/lib/md4.c,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -p -r1.4 -r1.5
--- md4.c 22 Oct 2005 16:32:14 -0000 1.4
+++ md4.c 10 May 2006 13:37:20 -0000 1.5
@@ -1,6 +1,6 @@
/* Functions to compute MD4 message digest of files or memory blocks.
according to the definition of MD4 in RFC 1320 from April 1992.
- Copyright (C) 1995,1996,1997,1999,2000,2001,2002,2003,2005
+ Copyright (C) 1995,1996,1997,1999,2000,2001,2002,2003,2005,2006
Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify it
@@ -179,7 +179,7 @@ process_partial_block:;
return 0;
}
-/* Compute MD5 message digest for LEN bytes beginning at BUFFER. The
+/* Compute MD4 message digest for LEN bytes beginning at BUFFER. The
result is always in little endian byte order, so that a byte-wise
output yields to the wanted ASCII representation of the message
digest. */
@@ -273,8 +273,8 @@ md4_process_bytes (const void *buffer, s
/* --- Code below is the primary difference between md5.c and md4.c --- */
/* MD4 round constants */
-#define K1 0x5a827999L
-#define K2 0x6ed9eba1L
+#define K1 0x5a827999
+#define K2 0x6ed9eba1
/* Round functions. */
#define F(x, y, z) ((z) ^ ((x) & ((y) ^ (z))))
- Re: test failures: crc, md4, gc-md4,
Simon Josefsson <=