Re: Openat and localcharset issues on Darwin

[Jim Meyering]

"Sergey Poznyakoff" <address@hidden> wrote:
> Hello,
>
> The following gnulib-related message was obtained while compiling GNU
> tar on powerpc-apple-darwin8.6.0 with GCC 4.1.1 and native ld:
>
> openat.c: In function 'rpl_openat':
> openat.c:60: warning: 'mode_t' is promoted to 'int' when passed through '...'
> openat.c:60: warning: (so you should pass 'int' not 'mode_t' to 'va_arg')
> openat.c:60: note: if this code is reached, the program will abort
>
> /usr/bin/ld: warning multiple definitions of symbol _locale_charset
> ../lib/libtar.a(localcharset.o) definition of _locale_charset in section 
> (__TEXT,__text)
> /usr/lib/libiconv.dylib(localcharset.o) definition of _locale_charset

Hi Sergey,

Does changing this line:
      if (sizeof (mode_t) < sizeof (int))
to this:
      if (sizeof (mode_t) <= sizeof (int))

avoid the warning?