bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: typo fix for fcntl_h.m4


From: Jim Meyering
Subject: FYI: typo fix for fcntl_h.m4
Date: Mon, 25 Sep 2006 15:02:18 +0200

The intent is to exit nonzero if open-nofollow succeeds on a symlink,
not only in the highly unlikely (probably impossible, in a configure script)
event it returns FD 0.

2006-09-25  Jim Meyering  <address@hidden>

        * fcntl_h.m4 (gl_FCNTL_H): Fix typo in test for failed open.
        This typo caused coreutils/tests/dd/misc to fail on Darwin 8.7.0.

Index: m4/fcntl_h.m4
===================================================================
RCS file: /sources/gnulib/gnulib/m4/fcntl_h.m4,v
retrieving revision 1.1
diff -u -r1.1 fcntl_h.m4
--- m4/fcntl_h.m4       28 Aug 2006 22:59:17 -0000      1.1
+++ m4/fcntl_h.m4       25 Sep 2006 12:57:32 -0000
@@ -29,7 +29,7 @@
              {
                if (symlink (".", sym) != 0)
                  return 1;
-               if (open (sym, O_RDONLY | O_NOFOLLOW) == 0)
+               if (0 <= open (sym, O_RDONLY | O_NOFOLLOW))
                  return 1;
              }
            return !constants;]])],




reply via email to

[Prev in Thread] Current Thread [Next in Thread]