[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: some missing module dependencies
From: |
Ralf Wildenhues |
Subject: |
Re: some missing module dependencies |
Date: |
Mon, 25 Sep 2006 19:36:04 +0200 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Hello Jim,
* Jim Meyering wrote on Fri, Sep 22, 2006 at 09:13:41AM CEST:
> Ralf Wildenhues <address@hidden> wrote:
> >
> > Is this patch ok, or would you rather factor out clock_time.m4 into its
> > own module (as it is listed by 3 modules already)?
> It's a tiny bit nicer to alphabetize lists e.g., of module names
> and file names.
Done.
> > * modules/nanosleep: Need m4/clock_time.m4.
>
> I too prefer module-based dependencies.
> You're welcome to create the new module.
Done. I hope it's ok to list you as maintainer. I've applied as shown
below.
Thanks for the review!
Cheers,
Ralf
* modules/clock-time: New module.
* modules/nanosleep (Depends-on): Add clock-time.
* modules/gethrxtime (Depends-on): Likewise.
* modules/gettime (Depends-on): Likewise.
* modules/settime (Depends-on): Likewise.
* modules/fts-lgpl: Depend on openat.
* modules/mkancesdirs: Depend on savewd.
* modules/mkdir-p: Likewise.
--- /dev/null 2006-09-21 00:13:29.348322750 +0200
+++ modules/clock-time 2006-09-25 19:28:28.000000000 +0200
@@ -0,0 +1,21 @@
+Description:
+Check for clock_gettime and clock_settime.
+
+Files:
+m4/clock_time.m4
+
+Depends-on:
+extensions
+
+configure.ac:
+gl_CLOCK_TIME
+
+Makefile.am:
+
+Include:
+
+License:
+GPL
+
+Maintainer:
+Jim Meyering
Index: modules/fts-lgpl
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/fts-lgpl,v
retrieving revision 1.2
diff -u -r1.2 fts-lgpl
--- modules/fts-lgpl 27 May 2005 23:59:22 -0000 1.2
+++ modules/fts-lgpl 25 Sep 2006 17:32:47 -0000
@@ -8,6 +8,7 @@
Depends-on:
dirfd
+openat
stdbool
configure.ac:
Index: modules/gethrxtime
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/gethrxtime,v
retrieving revision 1.4
diff -u -r1.4 gethrxtime
--- modules/gethrxtime 21 Aug 2006 21:46:31 -0000 1.4
+++ modules/gethrxtime 25 Sep 2006 17:32:47 -0000
@@ -6,10 +6,10 @@
lib/gethrxtime.c
lib/gethrxtime.h
m4/gethrxtime.m4
-m4/clock_time.m4
m4/longlong.m4
Depends-on:
+clock-time
gettime
extensions
Index: modules/gettime
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/gettime,v
retrieving revision 1.7
diff -u -r1.7 gettime
--- modules/gettime 31 Aug 2006 07:00:50 -0000 1.7
+++ modules/gettime 25 Sep 2006 17:32:47 -0000
@@ -3,10 +3,10 @@
Files:
lib/gettime.c
-m4/clock_time.m4
m4/gettime.m4
Depends-on:
+clock-time
gettime
gettimeofday
timespec
Index: modules/mkancesdirs
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/mkancesdirs,v
retrieving revision 1.3
diff -u -r1.3 mkancesdirs
--- modules/mkancesdirs 16 Sep 2006 19:58:25 -0000 1.3
+++ modules/mkancesdirs 25 Sep 2006 17:32:47 -0000
@@ -9,6 +9,7 @@
Depends-on:
dirname
fcntl
+savewd
stat-macros
configure.ac:
Index: modules/mkdir-p
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/mkdir-p,v
retrieving revision 1.9
diff -u -r1.9 mkdir-p
--- modules/mkdir-p 28 Aug 2006 22:59:17 -0000 1.9
+++ modules/mkdir-p 25 Sep 2006 17:32:47 -0000
@@ -16,6 +16,7 @@
lchown
mkancesdirs
quote
+savewd
stat-macros
stdbool
Index: modules/nanosleep
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/nanosleep,v
retrieving revision 1.7
diff -u -r1.7 nanosleep
--- modules/nanosleep 2 Mar 2006 07:36:42 -0000 1.7
+++ modules/nanosleep 25 Sep 2006 17:32:47 -0000
@@ -6,6 +6,7 @@
m4/nanosleep.m4
Depends-on:
+clock-time
timespec
stdbool
extensions
Index: modules/settime
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/settime,v
retrieving revision 1.6
diff -u -r1.6 settime
--- modules/settime 2 Mar 2006 07:36:42 -0000 1.6
+++ modules/settime 25 Sep 2006 17:32:47 -0000
@@ -3,12 +3,12 @@
Files:
lib/settime.c
-m4/clock_time.m4
m4/settime.m4
Depends-on:
-timespec
+clock-time
extensions
+timespec
configure.ac:
gl_SETTIME